Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add word-break to organization name and description #26624

Merged
merged 7 commits into from
Oct 25, 2023
Merged

Add word-break to organization name and description #26624

merged 7 commits into from
Oct 25, 2023

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Aug 21, 2023 •
edited
Loading

Fix #24318

Before:
image
image
image

After:
image
image
image
image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 21, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 21, 2023
@yp05327 yp05327 added the topic/ui Change the appearance of the Gitea UI label Aug 21, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 21, 2023
@lunny lunny added this to the 1.21.0 milestone Aug 21, 2023
@yp05327
Copy link
Contributor Author

yp05327 commented Aug 21, 2023

shared/user/org_profile_avatar and org/header have almost same codes.
I will improve this in another PR after this one finished.

@yp05327
Copy link
Contributor Author

yp05327 commented Aug 22, 2023

image
This still seems not good enough. 🤔

In GitHub:
https://github.com/yp05327/asdasdasdasdasdasdasdasdasdasdasdasdasdasdasdasdasdasdasdasdasdasdasdasdasdasdasdasdasdasdasdasdasda
image

@yp05327
Copy link
Contributor Author

yp05327 commented Aug 24, 2023

↑
Maybe we can improve this in another PR to change the design.
For example, convert owner name into owner's avatar with tooltip, and adjust the font size of repo name.
To make sure, at least in a normal maximized browser, repo name with 100 characters has no word break.

@lunny lunny modified the milestones: 1.21.0, 1.22.0 Sep 21, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 24, 2023
@puni9869
Copy link
Member

puni9869 commented Oct 24, 2023 •
edited
Loading

@yp05327 is this PR complete?
also is there any impact on mobile view port.

@yp05327
Copy link
Contributor Author

yp05327 commented Oct 25, 2023

Before:
image
image
image
image

After:
image
image
image
image

Maybe this is not related to this PR:
image

@delvh delvh added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 25, 2023
@lunny lunny enabled auto-merge (squash) October 25, 2023 10:01
@lunny lunny merged commit f39256f into go-gitea:main Oct 25, 2023
25 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 25, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 25, 2023
@zjjhot
Merge remote-tracking branch 'giteaoffical/main'
0d4b119 
* giteaoffical/main:
  Fix issue not showing on default board and add test (go-gitea#27720)
  Show placeholder email in privacy popup (go-gitea#27770)
  Add word-break to organization name and description (go-gitea#26624)
  Add border to file tree 'sub-items' and add padding to 'item-file' (go-gitea#27593)
  Fix the missing repo count in new team page and edit team page (go-gitea#27743)
  Only show diff file tree when more than one file changed (go-gitea#27775)
  Add gap between diff boxes (go-gitea#27776)
@yp05327 yp05327 deleted the fix-24318 branch October 25, 2023 23:32
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@yp05327 @fuxiaohei
Add word-break to organization name and description (go-gitea#26624)
c1cd0ad 
Fix go-gitea#24318

Before:

![image](https://github.com/go-gitea/gitea/assets/18380374/38282e5e-0b4d-4568-a853-59352798e826)

![image](https://github.com/go-gitea/gitea/assets/18380374/79d89ee6-61f6-45a7-af0b-d1c23fead25a)

![image](https://github.com/go-gitea/gitea/assets/18380374/39b45fae-52e2-4697-b83a-7cd10f76ac43)

After:

![image](https://github.com/go-gitea/gitea/assets/18380374/09e8cfcf-0150-494e-9f63-0868f529da65)

![image](https://github.com/go-gitea/gitea/assets/18380374/d2c348d3-fe03-466a-a5f4-878b7a93a318)

![image](https://github.com/go-gitea/gitea/assets/18380374/7f75b807-300c-42d5-b2c3-bae9e45e3c08)

![image](https://github.com/go-gitea/gitea/assets/18380374/06eca901-f5cf-4100-bb65-92457ad106e3)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@puni9869 puni9869 puni9869 approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

No word break for org name and description
6 participants
@yp05327 @puni9869 @delvh @lunny @GiteaBot @techknowlogick